Fix bug when empty http proxy env var#18
Merged
Conversation
bram2000
changed the title
Conditionally sets HTTP and HTTPS proxy environment variables if a proxy is configured. If no proxy is specified in the configuration, it explicitly removes these environment variables. This prevents the application from attempting to use a potentially invalid or non-existent proxy when one is not intended to be used.
bram2000
force-pushed
the
fix-empty-http-proxy-bug
branch
from
1c74a15 to
99301d2
Compare
christopherjturner
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditionally sets HTTP and HTTPS proxy environment variables if a proxy is configured. If no proxy is specified in the configuration, it explicitly removes these environment variables.
This prevents the application from attempting to use a potentially invalid or non-existent proxy when one is not intended to be used.